Enhancement/#12999 - Add new RRM module settings for express setup by hussain-t · Pull Request #13117 · google/site-kit-wp

hussain-t · 2026-07-15T08:08:04Z

Summary

Addresses issue:

Add new RRM module settings for express setup #12999

Relevant technical choices

PR Author Checklist

My code is tested and passes existing unit tests.
My code has an appropriate set of unit tests which all pass.
My code is backward-compatible with WordPress 5.2 and PHP 7.4.
My code follows the WordPress coding standards.
My code has proper inline documentation.
I have added a QA Brief on the issue linked above.
I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Run the code.
Ensure the acceptance criteria are satisfied.
Reassess the implementation with the IB.
Ensure no unrelated changes are included.
Ensure CI checks pass.
Check Storybook where applicable.
Ensure there is a QA Brief.
Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

Ensure the PR has the correct target branch.
Double-check that the PR is okay to be merged.
Ensure the corresponding issue has a ZenHub release assigned.
Add a changelog message to the issue.

…in RRM module.

… module settings.

…M module data store.

github-actions · 2026-07-15T08:11:05Z

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📚 Storybook for 9fd7d78:

Storybook has been deleted.

📦 Build files for 9fd7d78:

Build files have been deleted.

🎭 Playwright reports for 9fd7d78:

Reports have been deleted.

github-actions · 2026-07-15T08:13:45Z

Size Change: 0 B

Total Size: 3.71 MB

ℹ️ View Unchanged

Filename	Size	Change
`dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css`	124 B	0 B
`dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js`	0 B	0 B	🆕
`dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js`	42.9 kB	0 B
`dist/assets/blocks/reader-revenue-manager/common/editor-styles.css`	307 B	0 B
`dist/assets/blocks/reader-revenue-manager/common/editor-styles.js`	0 B	0 B	🆕
`dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js`	6.01 kB	0 B
`dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js`	5.21 kB	0 B
`dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js`	6.02 kB	0 B
`dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js`	5.21 kB	0 B
`dist/assets/blocks/sign-in-with-google/editor-styles.css`	84 B	0 B
`dist/assets/blocks/sign-in-with-google/editor-styles.js`	0 B	0 B	🆕
`dist/assets/blocks/sign-in-with-google/index.js`	18.5 kB	0 B
`dist/assets/css/googlesitekit-admin-css-********************.min.css`	72.8 kB	0 B
`dist/assets/css/googlesitekit-adminbar-css-********************.min.css`	12.7 kB	0 B
`dist/assets/css/googlesitekit-authorize-application-css-********************.min.css`	851 B	0 B
`dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css`	9.09 kB	0 B
`dist/assets/js/46-********************.js`	3.84 kB	0 B
`dist/assets/js/65-********************.js`	1.03 kB	0 B
`dist/assets/js/187-********************.js`	101 kB	0 B
`dist/assets/js/308-********************.js`	3 kB	0 B
`dist/assets/js/315-********************.js`	3.08 kB	0 B
`dist/assets/js/397-********************.js`	477 kB	0 B
`dist/assets/js/403-********************.js`	2.26 kB	0 B
`dist/assets/js/509-********************.js`	970 B	0 B
`dist/assets/js/658-********************.js`	52.7 kB	0 B
`dist/assets/js/917-********************.js`	2.41 kB	0 B
`dist/assets/js/analytics-advanced-tracking-********************.js`	404 B	0 B
`dist/assets/js/googlesitekit-activation-********************.js`	27.3 kB	0 B
`dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	65.7 kB	0 B
`dist/assets/js/googlesitekit-admin-pointers-tracking-********************.js`	5.37 kB	0 B
`dist/assets/js/googlesitekit-adminbar-********************.js`	41 kB	0 B
`dist/assets/js/googlesitekit-api-********************.js`	8.04 kB	0 B
`dist/assets/js/googlesitekit-block-tracking-********************.js`	5.56 kB	0 B
`dist/assets/js/googlesitekit-components-********************.js`	6.28 kB	0 B
`dist/assets/js/googlesitekit-consent-mode-********************.js`	26 kB	0 B
`dist/assets/js/googlesitekit-data-********************.js`	1.83 kB	0 B
`dist/assets/js/googlesitekit-datastore-forms-********************.js`	7.21 kB	0 B
`dist/assets/js/googlesitekit-datastore-location-********************.js`	1.6 kB	0 B
`dist/assets/js/googlesitekit-datastore-pdf-********************.js`	1.2 kB	0 B
`dist/assets/js/googlesitekit-datastore-site-********************.js`	19 kB	0 B
`dist/assets/js/googlesitekit-datastore-ui-********************.js`	7.37 kB	0 B
`dist/assets/js/googlesitekit-datastore-user-********************.js`	23.7 kB	0 B
`dist/assets/js/googlesitekit-entity-dashboard-********************.js`	79.6 kB	0 B
`dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js`	2.35 kB	0 B
`dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js`	1.12 kB	0 B
`dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js`	2.34 kB	0 B
`dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js`	2.3 kB	0 B
`dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js`	2.22 kB	0 B
`dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js`	2.44 kB	0 B
`dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js`	1.08 kB	0 B
`dist/assets/js/googlesitekit-events-provider-wpforms-********************.js`	2.44 kB	0 B
`dist/assets/js/googlesitekit-i18n-********************.js`	4.43 kB	0 B
`dist/assets/js/googlesitekit-key-metrics-setup-********************.js`	59.7 kB	0 B
`dist/assets/js/googlesitekit-main-dashboard-********************.js`	209 kB	0 B
`dist/assets/js/googlesitekit-metric-selection-********************.js`	64.8 kB	0 B
`dist/assets/js/googlesitekit-modules-********************.js`	27.9 kB	0 B
`dist/assets/js/googlesitekit-modules-ads-********************.js`	49.7 kB	0 B
`dist/assets/js/googlesitekit-modules-adsense-********************.js`	160 kB	0 B
`dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	280 kB	0 B
`dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	27.4 kB	0 B
`dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js`	55.7 kB	+34 B (+0.06%)
`dist/assets/js/googlesitekit-modules-search-console-********************.js`	75.8 kB	0 B
`dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js`	35.1 kB	0 B
`dist/assets/js/googlesitekit-modules-tagmanager-********************.js`	32 kB	0 B
`dist/assets/js/googlesitekit-notifications-********************.js`	85.1 kB	0 B
`dist/assets/js/googlesitekit-polyfills-********************.js`	228 B	0 B
`dist/assets/js/googlesitekit-settings-********************.js`	167 kB	0 B
`dist/assets/js/googlesitekit-splash-********************.js`	90.7 kB	0 B
`dist/assets/js/googlesitekit-user-input-********************.js`	57 kB	0 B
`dist/assets/js/googlesitekit-vendor-********************.js`	791 kB	0 B
`dist/assets/js/googlesitekit-vendor-lazy-pdf-********************.js`	19 kB	0 B
`dist/assets/js/googlesitekit-widgets-********************.js`	178 kB	0 B
`dist/assets/js/googlesitekit-wp-dashboard-********************.js`	68.6 kB	0 B
`dist/assets/js/runtime-********************.js`	1.94 kB	0 B
`dist/assets/js/sign-in-with-google-********************.js`	1.14 kB	0 B

_{compressed-size-action}

…settings.

nfmohit

Fantastic work here, thanks @hussain-t! I've left a few comments for your consideration. LMKWYT, thanks!

…settings.

…d of a helper.

…slugs in RRM store.

… default settings of RRM module.

…ithub.com:google/site-kit-wp into enhancement/#12999-add-rrm-express-setup-settings.

nfmohit

Thanks @hussain-t. I've added an additional comments, but it is very minor so I'll go ahead and apply this myself to save the round trip.

nfmohit

LGTM ✅

I've verified that the failing E2E and VRT tests are unrelated to the changes in this PR.

hussain-t added 4 commits July 15, 2026 13:35

Add organizationID and configuredCTAs settings with sanitization …

0ab9465

…in RRM module.

Add validation tests for organizationID and configuredCTAs in RRM…

652ee1d

… module settings.

Add organizationID and configuredCTAs to the RRM module store state.

932ffb4

Add test for retrieving organizationID and configuredCTAs from RR…

c4414b7

…M module data store.

Merge branch 'develop' into enhancement/#12999-add-rrm-express-setup-…

68180ac

…settings.

nfmohit requested changes Jul 17, 2026

View reviewed changes

Comment thread includes/Modules/Reader_Revenue_Manager/Settings.php Outdated

Comment thread tests/phpunit/integration/Modules/Reader_Revenue_Manager/SettingsTest.php

Comment thread assets/js/modules/reader-revenue-manager/datastore/base.test.js Outdated

hussain-t added 8 commits July 21, 2026 15:41

Merge branch 'develop' into enhancement/#12999-add-rrm-express-setup-…

d6324ed

…settings.

Remove unnecessary tests.

d725795

Refactor express setup settings sanitization to return results instea…

6397c5b

…d of a helper.

Update test assertions.

3fb57df

Integrate feature flag for organizationID and configuredCTAs setting …

3b97537

…slugs in RRM store.

Implement feature flag logic for organizationID and configuredCTAs in…

0fca0f0

… default settings of RRM module.

Add tests for default RRM settings and express setup flag behavior.

7313554

Merge branch 'enhancement/#12999-add-rrm-express-setup-settings' of g…

5ad78e3

…ithub.com:google/site-kit-wp into enhancement/#12999-add-rrm-express-setup-settings.

nfmohit requested changes Jul 22, 2026

View reviewed changes

Comment thread includes/Modules/Reader_Revenue_Manager/Settings.php

Add method to cast empty configuredCTAs to object.

9fd7d78

nfmohit approved these changes Jul 22, 2026

View reviewed changes

nfmohit merged commit bb1fa8b into develop Jul 22, 2026
43 of 45 checks passed

nfmohit deleted the enhancement/#12999-add-rrm-express-setup-settings branch July 22, 2026 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enhancement/#12999 - Add new RRM module settings for express setup#13117

Enhancement/#12999 - Add new RRM module settings for express setup#13117
nfmohit merged 14 commits into
developfrom
enhancement/#12999-add-rrm-express-setup-settings

hussain-t commented Jul 15, 2026 •

edited by nfmohit

Loading

Uh oh!

github-actions Bot commented Jul 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 15, 2026 •

edited

Loading

Uh oh!

nfmohit left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nfmohit left a comment

Uh oh!

Uh oh!

nfmohit left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hussain-t commented Jul 15, 2026 • edited by nfmohit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Relevant technical choices

PR Author Checklist

Code Reviewer Checklist

Merge Reviewer Checklist

Uh oh!

github-actions Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nfmohit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nfmohit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nfmohit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hussain-t commented Jul 15, 2026 •

edited by nfmohit

Loading

github-actions Bot commented Jul 15, 2026 •

edited

Loading

github-actions Bot commented Jul 15, 2026 •

edited

Loading