pybind: Drop get_ prefix from S2CellId and S2LatLng method names#632
Open
deustis wants to merge 1 commit into
Open
pybind: Drop get_ prefix from S2CellId and S2LatLng method names#632deustis wants to merge 1 commit into
deustis wants to merge 1 commit into
Conversation
Renames all Python methods whose C++ counterparts begin with Get: s2cell_id: size_ij, size_ij_for_level, size_st, size_st_for_level, center_st, bound_st, center_uv, bound_uv, common_ancestor_level, edge_neighbors, vertex_neighbors, all_neighbors. s2latlng: distance.
Contributor
Author
|
@jmr, broke out a separate PR for the other classes to address your comment here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames Python binding methods whose C++ names begin with
Get, following the convention that theGetprefix is dropped in Python.S2CellId:
size_ij,size_ij_for_level,size_st,size_st_for_level,center_st,bound_st,center_uv,bound_uv,common_ancestor_level,edge_neighbors,vertex_neighbors,all_neighborsS2LatLng:
distanceTest Plan