Add a reminder to run update_dependency to PR authors#3050
Merged
Conversation
weiminyu
force-pushed
the
reminder-2
branch
5 times, most recently
from
524cb51 to
ccfba27
Compare
gbrodman
requested changes
May 18, 2026
Collaborator
gbrodman
left a comment
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on njshah301 and weiminyu).
.github/workflows/update-dependency-reminder.yml line 46 at r1 (raw file):
repo: context.repo.repo, pull_number: context.payload.pull_request.number, event: 'COMMENT',
i think we want REQUEST_CHANGES so that it blocks the PR from merging until someone resolves it
After the public-access removal from GCS buckets, the Kokoro tests can no longer use our private repo for resolve dependencies. And breakage is discovered only during build. This PR lets Github to create review comment, which triggers on PRs that contain *.lockfile changes and asks the PR author to confirm that the update_dependency script has been executed.
Collaborator
Author
|
Previously, gbrodman wrote…
Done |
gbrodman
approved these changes
May 18, 2026
Collaborator
gbrodman
left a comment
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on njshah301).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the public-access removal from GCS buckets, the Kokoro tests can no longer use our private repo for resolve dependencies. And breakage is discovered only during build.
This PR lets Github to create review comment, which triggers on PRs that contain *.lockfile changes and asks the PR author to confirm that the update_dependency script has been executed.
Verified the scannin logic wrt lockfile changes. Review posting cannot be tested until it is merged.
Will test after the merge.
This change is