Generate partial phases kubernetes manifests in CB release job#3048
Open
jicelhay wants to merge 4 commits into
Open
Generate partial phases kubernetes manifests in CB release job#3048jicelhay wants to merge 4 commits into
jicelhay wants to merge 4 commits into
Conversation
gbrodman
approved these changes
May 15, 2026
Collaborator
gbrodman
left a comment
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jicelhay).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These manifests will be used in Cloud Deploy canary phases. They contain a new Deployment that is a copy of the "stable" deployment, but have a custom name, a fixed number of replicas (1 or 5 depending on the stage). They will canary the new nomulus image that's going to be deployed.
These files are not tracked artifacts in Spinnaker so even if they are generated when preparing a release, they shouldn't be deployed until we onboard Cloud Deploy to the release process.
b/507126629
This change is