ci: declare empty permissions for do-not-merge label check#3042
Open
arpitjain099 wants to merge 2 commits into
Open
ci: declare empty permissions for do-not-merge label check#3042arpitjain099 wants to merge 2 commits into
arpitjain099 wants to merge 2 commits into
Conversation
This workflow only checks the PR's labels and exits 1 if 'do not merge' is
present. It does not check out the repo, install anything, or call any
GitHub API — permissions: {} (no scopes at all) is correct here.
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
240ea98 to
7125f81
Compare
Author
|
Hi @gbrodman, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-approver side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Check labelsworkflow only readsgithub.event.pull_request.labels.*.nameand exits 1 ifdo not mergeis present. It does not check out the repo, install anything, or call any GitHub API.permissions: {}(deny all scopes) is the right default for this case.YAML parses cleanly.
This change is