Skip to content

Fix lint errors with Rust 1.89#296

Closed
theoparis wants to merge 1 commit into
google:masterfrom
theoparis:push-knunvmyrnmyo
Closed

Fix lint errors with Rust 1.89#296
theoparis wants to merge 1 commit into
google:masterfrom
theoparis:push-knunvmyrnmyo

Conversation

@theoparis
Copy link
Copy Markdown

@theoparis theoparis commented Sep 4, 2025

I added a PartialEq impl because of this error:

error: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique
  --> src-rs/func.rs:57:5
   |
54 | #[derive(PartialEq)]
   |          --------- in this derive macro expansion
...
57 |     pub func: MakeFuncImpl,
   |     ^^^^^^^^^^^^^^^^^^^^^^

@theoparis theoparis requested a review from a team as a code owner September 4, 2025 02:18
Comment thread src-rs/parser.rs
pub op: AssignOp,
}
pub fn parse_assign_statement(line: &[u8], sep: usize) -> ParsedAssign {
pub fn parse_assign_statement(line: &'_ [u8], sep: usize) -> ParsedAssign<'_> {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the lifetime on the argument, it's not necessary. Same in var.rs.

@Colecf
Copy link
Copy Markdown
Collaborator

Colecf commented Sep 17, 2025

Replaced with #298

@Colecf Colecf closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants