Don't display quotes around strings in --dump_stamp_tool#292
Conversation
To match ckati.
danw
left a comment
There was a problem hiding this comment.
Is the purpose here so that you can diff between ckati and rkati? In general the quoting is probably a good idea to make any oddities more obvious.
No, it's because this dump tool is used by other tools that expect to parse it in a specific format. I think this is the only real user, and they only use |
|
Even ignoring the string encoding issue in the inner comment, this interface really isn't great for parsing like that -- it's entirely valid for filenames to include newline characters, though I really hope nobody does that. (not to mention that the makefile syntax doesn't handle whitespace in filenames either) That file will also need to be updated to ignore rkati the way it ignores ckati. |
To match ckati.