Skip to content

Loosen LBFGSB test Rosenbrock assertion threshold to 1.5e-3. #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 4, 2026
+4 −3
Merged

Loosen LBFGSB test Rosenbrock assertion threshold to 1.5e-3. #642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/lbfgsb_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
except ImportError:
from jax.experimental import enable_x64

# Uncomment this line to test in x64
# Uncomment this line to test in x64
# jax.config.update('jax_enable_x64', True)

class LbfgsbTest(test_util.JaxoptTestCase):
Expand Down Expand Up @@ -100,7 +100,8 @@ def fun(x): # Rosenbrock function.
x, _ = lbfgsb.run(x0, bounds=(lower, upper))

# the Rosenbrock function is zero at its minimum
self.assertLessEqual(fun(x), 1e-3)
# Loosened to 1.5e-3 due to float32 precision limits after dot strength reduction on CPU.
self.assertLessEqual(fun(x), 1.5e-3)

@parameterized.parameters(
((0., -5., 0), (2., 0., 1)),
Expand Down Expand Up @@ -269,7 +270,7 @@ def fit_objective(pars, data, x):
data = jnp.array(1.5)
res = grad_fn(0.5, jnp.array(0.0), (jnp.array(0.0), jnp.array(10.0)), data)
self.assertEqual(res, data)

def test_linear_in_box(self):
# Fixing issue #492
def fun(x):
Expand Down
Loading