Sync some recent changes#129
Merged
Merged
Conversation
Changes build scripts to define new vulkan base/graphics/compute definitions. DISABLE_TOPIC_PROTECTOR Bug: 502904616 Bug: 500959073 Test: CI Change-Id: Ifc2e005711fbf9ab49e5d095012dbf2da2bd44fa
Ordering of the extensions was affecting the codegen and some structures were missing due to errors during codegen. One example is the custom border color structure for the samplers, due to the reference from new vkRegisterCustomBorderColorEXT function that's introduced with a different extension VK_EXT_descriptor_heap. This CL adds a sorting mechanism to generate code for supported extensions first to ensure deepcopy and transform functions are created correctly. Bug: 507064848 Bug: 507339722 Bug: 514574958 Test: dEQP-VK.pipeline.* Change-Id: Ib15abebe75c23aca06ba6503b9ed2258096760ed
Bug: 513476728 Change-Id: I6f11e7a777ce6dea0a1e80a290b285220ba04fbf
Bug: 515295669 Change-Id: I795ee1585971a007a2f41f4baae2c5bbe38422df
kocdemir
approved these changes
Jun 1, 2026
Bug: b/511887593 Test: cvd create --gpu_mode=gfxstream_guest_angle Change-Id: I0912059d2bf2371f39e543e249d1a75111781c1d
Adds a new codegen flag to ensure that the decoder passes through the buffer sizes to the underlying server (i.e. FrameBuffer). Updates callers of readPixels() to pass through the size. Updates readContents() to pass the std::vector directly and removes unused glOpReadContents() which routed to this function. Bug: b/508646086 Bug: b/511886994 Test: cvd create --gpu_mode=gfxstream_guest_angle Change-Id: I94f1c7b77a98f04ceb63a693a979ec112415cba1
Due to timing issues (e.g., during rapid surface recreation or rotation), the system may fail to import zero-copy resources and fall back to the copy-path. If this occurs, `mLinear` might be empty, leading to a host-side null pointer dereference crash. This CL adds robust defensive checks to `ReadFromPipeToLinear`, `ReadFromBufferToLinear`, and `ReadFromColorBufferToLinear` to verify that `mLinear` is allocated and large enough before copying, safely returning `-EINVAL` otherwise. Bug: 511078953 Test: Verified host stability under forced fallback and rapid orientation transitions. Change-Id: I300d383ffb50ba7378518378cd5bde47d37541d9
to only write at most std::min(requested, available) pool ids. Bug: b/511887710 Test: cvd create --gpu_mode=gfxstream_guest_angle Change-Id: Iaf3dae838a4ad20fa72b0ba8c9dcf186cc3b735f
`VkDeviceDeviceMemoryReportCreateInfoEXT::pUserData` was updated to have `optional` sometime between v1.4.335 and v1.4.337 which updates codegen in a backwards incompatible way. VkDeviceDeviceMemoryReportCreateInfoEXT should not really be sent to the host anyways (as a guest provided callback can never be called from the host) but older existing guest images are already sending this struct so we need to preserve compatibility. Bug: b/519606352 Test: GfxstreamEnd2EndTests Change-Id: I51252846736ecb2c1fb57a0e8e42c3443e030143
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.