Skip to content

Fix flash_attention_test link error on multi-target SIMD builds #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plawanrath wants to merge 1 commit into
base: dev
Choose a base branch
from
+10 −0
Open

Fix flash_attention_test link error on multi-target SIMD builds #917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,18 @@ set(GEMMA_ENABLE_TESTS OFF CACHE BOOL "Enable Gemma tests")
if (GEMMA_ENABLE_TESTS)

enable_testing()
find_package(GTest REQUIRED)
include(GoogleTest)

# Tests use HWY_IS_TEST=1 with `hwy/foreach_target.h`, which expands the test
# TU for every attainable SIMD target (including EMU128). libgemma's
# foreach_target sources (flash_attention.cc, attention.cc, gemma.cc, vit.cc)
# normally compile only for the baseline+best targets, so tests would fail to
# link against per-target symbols like N_EMU128::FlashAttention. Build
# libgemma for all attainable targets when tests are enabled, matching what
# the tests reference.
target_compile_definitions(libgemma PRIVATE HWY_IS_TEST=1)

set(GEMMA_TEST_FILES
compression/compress_test.cc
compression/distortion_test.cc
Expand Down