Update test_font_tags.py#10689
Open
aaronbell wants to merge 5 commits into
Open
Conversation
Allow zero state for tags if at a non-default location
Now, a "providence" column has been added to families.csv to differentiate between human-created tags and machine-predicted tags. I've also asked Gemini to review files that rely on this data to fix any scenarios that break as a result of this modification. It has updated several processes as a result.
This reverts commit 405b1e7.
Collaborator
Author
|
I pushed the commit to the wrong place. Reverted. PR is now only related to the zero state update. |
Now up to 47,000 tags
This reverts commit 6d36edf.
Collaborator
|
I see the issue but I'm not too sure if this is the best solution. I can raise this in +oncall. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In adding a bunch of new tag data to the
families.csv, I realized that there are situations where a tag may be active at the default location (MONO@0), but be inactive at a different location (MONO@1). "Monospace/Monospace" is a great example which can be set to 100 at the default location but needs to be set to 0 at other instances on the variable axis.This PR implements a change to the test_font_tags file to allow this to occur. It is required for #10688 to move forward.