Skip to content

TooManyParameters: treat any annotation containing "Inject" as a stop-annotation. #5274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 16, 2025
Merged

TooManyParameters: treat any annotation containing "Inject" as a stop-annotation. #5274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/src/main/java/com/google/errorprone/bugpatterns/TooManyParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ public class TooManyParameters extends BugChecker implements MethodTreeMatcher {
"java.lang.Deprecated",
"java.lang.Override",
// dependency injection annotations
"jakarta.inject.Inject",
"javax.inject.Inject",
"com.google.inject.Inject",
"com.google.inject.Provides",
// JUnit @Test methods are never directly invoked (most of the time they don't even have
// parameters, unless it's a parameterized test --- which still are not directly
Expand Down Expand Up @@ -108,6 +105,10 @@ private static boolean shouldApplyApiChecks(MethodTree tree, VisitorState state)
if (isRecord(symbol)) {
return false;
}
if (tree.getModifiers().getAnnotations().stream()
.anyMatch(a -> getSymbol(a).getSimpleName().toString().contains("Inject"))) {
return false;
}
return METHOD_ANNOTATIONS_TO_IGNORE.stream().noneMatch(a -> hasAnnotation(tree, a, state))
&& methodIsPublicAndNotAnOverride(symbol, state);
}
Expand Down
Loading