Rename isWildcard to isEffectivelyWildcard and have it check the java representation for wildcards too.#5173
Merged
Merged
Conversation
…java representation for wildcards too. The current `isWildcard` method is poorly named because for Kotlin types it only captures the use-site variance. However, in Dagger we almost always care about the "effective" variance, which depends on many other factors like delcaration-site variance. This CL renames `isWildcard` to `isEffectivelyWildcard` and updates the implementation to check the java representation for wildcards. RELNOTES=N/A PiperOrigin-RevId: 919796256
copybara-service
Bot
force-pushed
the
test_918691979
branch
from
b7b768b to
ee224b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
isWildcardtoisEffectivelyWildcardand have it check the java representation for wildcards too.The current
isWildcardmethod is poorly named because for Kotlin types it only captures the use-site variance. However, in Dagger we almost always care about the "effective" variance, which depends on many other factors like delcaration-site variance.This CL renames
isWildcardtoisEffectivelyWildcardand updates the implementation to check the java representation for wildcards.RELNOTES=N/A