Support generic parameters in cpp_layout_equivalent#1093
Open
copybara-service[bot] wants to merge 1 commit into
Open
Support generic parameters in cpp_layout_equivalent#1093copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
This change adds support for generic parameters to `crubit_annotate::cpp_layout_equivalent` in `cpp_api_from_rust`. This allows mapping Rust APIs that use generic types like `cc_std::unique_ptr` and `cc_std::optional` back into C++ by building on the existing `layout_equivalent` support. - Relaxed pointer restrictions for `cpp_layout_equivalent` in `format_type.rs` and `generate_function_thunk.rs`. - Added support for generic parameters in `format_type.rs` for `Legacy` types. - Fixed parameter conversion in thunks to read from pointer for non-pointers. - Added a test case in `bridging` directory. PiperOrigin-RevId: 922308817
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support generic parameters in cpp_layout_equivalent
This change adds support for generic parameters to
crubit_annotate::cpp_layout_equivalentincpp_api_from_rust. This allows mapping Rust APIs that use generic types likecc_std::unique_ptrandcc_std::optionalback into C++ by building on the existinglayout_equivalentsupport.cpp_layout_equivalentinformat_type.rsandgenerate_function_thunk.rs.format_type.rsforLegacytypes.bridgingdirectory.