Fix overload conflict avoidance for Index / IndexMut.#1083
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix overload conflict avoidance for Index / IndexMut.#1083copybara-service[bot] wants to merge 1 commit into
Index / IndexMut.#1083copybara-service[bot] wants to merge 1 commit into
Conversation
Before this CL, only top-level types would be analyzed for potential conflicts (e.g. `usize` and `u64` may both map to the same C++ type). This means that conflicts involving nested types may go unnoticed, leading to C++ compilation errors (e.g. when `(usize, bool)` and `(u64, bool)` tuple types both map to the same C++ type). This CL fixes this: * The conflict avoidance code was moved into a small, separate crate for additional encapsulation and unit test coverage. * The conflict avoidance code was made independent of `usize` / `isize` (based on the concept of a "vip" type). * Recursive destructuring of types has been added to the `get_vip` function PiperOrigin-RevId: 921550952
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix overload conflict avoidance for
Index/IndexMut.Before this CL, only top-level types would be analyzed for potential
conflicts (e.g.
usizeandu64may both map to the same C++ type).This means that conflicts involving nested types may go unnoticed,
leading to C++ compilation errors (e.g. when
(usize, bool)and(u64, bool)tuple types both map to the same C++ type).This CL fixes this:
for additional encapsulation and unit test coverage.
usize/isize(based on the concept of a "vip" type).
get_vipfunction