[Swarming] Crash service on startup #5285
Draft
IvanBM18 wants to merge 11 commits into
Draft
Conversation
Co-authored-by: Titouan Rigoudy <titouan@chromium.org>
IvanBM18
changed the title
IvanBM18
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
SwarmingServiceand other remote task services are now instantiated inRemoteTaskGatebased on the their feature flag.To prevent silent failures, the SwarmingService will now crash on startup if the
apiis not instantiated correctly. Also if the this should only happen in environments where the linked feature flag is enabled.Changes
SwarmingServiceconstructor if the swarming config was not foundRemoteTaskGateto conditionally instantiate services based on the linked feature flag.