Prompt users on instance operations#2547
Draft
cjreynol wants to merge 14 commits into
Draft
Conversation
cjreynol
force-pushed
the
prompt_for_instance_operations
branch
2 times, most recently
from
4e8b947 to
0367db2
Compare
cjreynol
force-pushed
the
prompt_for_instance_operations
branch
3 times, most recently
from
8a0abdd to
9af976a
Compare
To behave like `FindGroupOrDefault`, to help set up prompting for instances. Bug: 511316553
Bug: 511316553
Likely it was intended to support setting the filter based on the value of the environment variable, but there does not seem to be a problem with the value being unused. The flags are still available, so no filtering functionality is lost
The previous logic was relying upon knowing the behavior of the helpers to be aware the `Result` returned was signaling too many groups being returned. That is somewhat overloading the meaning of a `Result`, and not clear to potential future refactors that specific behavior was being relied upon. The new logic is explicit about the various cases. Bug: 511316553
The same idea as the previous `SelectGroup` commit, stop relying on implicit behavior from helpers and trying to signal certain caes through `Result` returning, and be explicit about the various cases. Bug: 511316553
Need to refactor some of the logic in `PromptUserForGroup` to allow it to be re-used for instance selection. Bug: 511316553
Bug: 511316553
Bug: 511316553
And remove the ability to type in group/instance names during selection steps.
cjreynol
force-pushed
the
prompt_for_instance_operations
branch
from
f496d80 to
a294e4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an instance-focused operation (
logs) is not given selectors, then havecvdprompt the user to select an instance rather than failing. This matches what we do for group-focused operations (remove).Bug: 511316553