fix: avoid ApiServer scope shadowing in web reload#5769
Open
he-yufeng wants to merge 2 commits into
Open
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for creating this PR! This PR looks great and addresses issue #5765! To fully follow our contribution guidelines, could you please:
This will help reviewers understand and approve your changes much faster. Thank you! |
Collaborator
|
Hi @he-yufeng , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors by running autoformat.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiServerimports inget_fast_api_appweb=Trueplusreload_agents=TruewhileDevServeris availableFixes #5765
To verify
.\.venv\Scripts\python.exe -m py_compile src\google\adk\cli\fast_api.py tests\unittests\cli\test_fast_api.py.\.venv\Scripts\python.exe -m pytest tests/unittests/cli/test_fast_api.py::test_web_reload_agents_uses_module_api_server_import -q -p no:cacheprovideruv run --extra dev pyink --check src\google\adk\cli\fast_api.py tests\unittests\cli\test_fast_api.pygit diff --checkNotes
uv run --extra test ...currently cannot resolve the locked test environment on Windows becauseyarl==1.24.1has nowin_amd64wheel or source distribution.