fix: correct triage agent paths#5757
Open
fancydirty wants to merge 3 commits into
Open
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @fancydirty, thank you for creating this PR! This PR is a bug fix. To align fully with our contribution guidelines, could you please:
This information will help reviewers to review your PR more efficiently. Thanks! |
Collaborator
|
Hi @fancydirty , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing unit tests before we can proceed with the review. |
Author
|
Hi @rohityan, thanks for the review. I updated the PR description to include a dedicated testing plan section and local verification output for the corrected PYTHONPATH/module resolution. I also refreshed the branch checks after the old failed run; current PR checks are green on my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes import paths for the ADK issue and pull request triaging workflows.
The workflows previously set PYTHONPATH to contributing/samples, but both packages live under contributing/samples/adk_team:
As a result, the PR triage job could fail before it could run:
This PR changes both triage workflows to use PYTHONPATH=contributing/samples/adk_team.
It also fixes the PR triaging agent CONTRIBUTING.md lookup. The previous parents[3] path resolved to contributing/CONTRIBUTING.md, but the file is in the repository root, so the correct path is parents[4] / CONTRIBUTING.md.
testing plan
Verified locally with corrected PYTHONPATH and dummy workflow environment variables in the Python 3.10 uv test environment.
Command summary:
Verification output: