chore: drop google-genai from requirements#139
Merged
Conversation
adk includes genai in its dependency list
Collaborator
|
@gemini-cli /review |
|
🤖 Hi @DeanChensj, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
I've analyzed the PR and found that google-genai is still a required dependency for several modules in the codebase.
Specifically, S3ArtifactService and OpenMemoryService rely on google.genai.types for their public API and internal logic. Removing this dependency from pyproject.toml without refactoring those services will lead to ImportError at runtime and failures in the unit tests.
I recommend either:
- Keeping the dependency if these services are intended to stay as-is.
- Refactoring the services to remove their reliance on
google-genaitypes before dropping the dependency.
DeanChensj
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adk-pythonincludesgoogle-genaiin its dependency list