Skip to content

chore: drop google-genai from requirements#139

Merged
DeanChensj merged 1 commit into
google:mainfrom
haranrk:chore/upgrade-genai-sdk
May 18, 2026
Merged

chore: drop google-genai from requirements#139
DeanChensj merged 1 commit into
google:mainfrom
haranrk:chore/upgrade-genai-sdk

Conversation

@haranrk
Copy link
Copy Markdown
Contributor

@haranrk haranrk commented May 18, 2026

adk-python includes google-genai in its dependency list

adk includes genai in its dependency list
@haranrk haranrk changed the title chore: drop genai from requirements chore: drop google-genai from requirements May 18, 2026
@DeanChensj
Copy link
Copy Markdown
Collaborator

@gemini-cli /review

@github-actions
Copy link
Copy Markdown

🤖 Hi @DeanChensj, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've analyzed the PR and found that google-genai is still a required dependency for several modules in the codebase.

Specifically, S3ArtifactService and OpenMemoryService rely on google.genai.types for their public API and internal logic. Removing this dependency from pyproject.toml without refactoring those services will lead to ImportError at runtime and failures in the unit tests.

I recommend either:

  1. Keeping the dependency if these services are intended to stay as-is.
  2. Refactoring the services to remove their reliance on google-genai types before dropping the dependency.

Comment thread pyproject.toml
@DeanChensj DeanChensj merged commit 647c6c0 into google:main May 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants