fix: ensure --check validates copyright holder with -c#172
Open
Aswinr24 wants to merge 6 commits into
Open
Conversation
3 tasks
Contributor
|
Thanks for contributing to addlicense! As mentioned in #164, I have concerns about this feature; please say more in that issue about how you think projects with heterogenous copyright holders should be handled. Since this is a significant change, please pull the empty-file and .spec changes into their own PRs. |
Contributor
|
Friendly ping @Aswinr24. I'm interested in the empty-file fix and .spec change, could you move those to their own PRs? I think there's value in the copyright holder check, but I'd like to work out the semantics first for minimal disruption. |
|
Checking the status on this. I'd really like the empty-file feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that when using --check with -c "Copyright Holder", addlicense verifies that the copyright holder matches the expected value instead of just checking for a license header.
Additionally, this PR:
.specfiles, ensuring they receive license headers.Changes Made
.specfiles.Test Output:
addlicense -c "Google LLC" --check testdata/initial/file.csBefore Fix:
testdata/expected/file.csAfter Fix:
testdata/expected/file.cs: incorrect copyright holder (expected: Google LLC, found: Meta Platforms)Tests & Verification
All unit tests passed successfully.
Closes #164 , Closes #162 , Closes #163