ci(release): build and attach unsigned macOS binaries to releases#26462
ci(release): build and attach unsigned macOS binaries to releases#26462
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the release process by automating the generation and distribution of unsigned macOS binaries. By integrating these artifacts into existing CI/CD workflows, the project ensures that macOS users have access to platform-specific builds directly from the release page, streamlining the deployment pipeline. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Hi @ruomengz, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Size Change: -4 B (0%) Total Size: 34 MB
ℹ️ View Unchanged
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the release process in the publish-release action to dynamically include macOS binaries if they are present in the distribution directory. By checking for the existence of darwin-arm64 and darwin-x64 binaries and adding them to the release assets array, the workflow now supports multi-platform release artifacts. I have no feedback to provide as there are no review comments.
gemini-cli
Bot
added
the
status/need-issue
ruomengz
added
area/core
gemini-cli
Bot
added
the
status/need-issue
- Add a `build-mac` job to the nightly, manual, and promote release workflows to build unsigned macOS binaries for both `x64` and `arm64` architectures. - Update the publication jobs to require the new `build-mac` step and download the resulting artifacts. - Modify the `publish-release` action to include the macOS binaries as assets in the GitHub release if they exist.
- Extracted macOS build job into a reusable workflow .github/workflows/build-unsigned-mac-binaries.yml - Created a composite action .github/actions/download-mac-binaries to download the built binaries. - Updated release-manual.yml, release-nightly.yml, and release-promote.yml to use the shared workflow and action.
4 participants
Summary
Adds a
build-macjob to the nightly, manual, and promote release workflows to automatically build unsigned macOS binaries (x64andarm64) and attach them as release assets.Details
build-macstep to.github/workflows/release-manual.yml,.github/workflows/release-nightly.yml, and.github/workflows/release-promote.yml.gemini-darwin-arm64-unsignedandgemini-darwin-x64-unsignedartifacts..github/actions/publish-release/action.ymlto automatically append these macOS binaries toRELEASE_ASSETSwhen creating a GitHub release.Related Issues
https://github.com/google-gemini/maintainers-gemini-cli/issues/1649
How to Validate
Release: Manualworkflow on this branch.build-macjob successfully runs and generates the unsigned artifacts.Pre-Merge Checklist