Skip to content

Fix typos in LoRA einsum utils docstring#655

Open
AshNicolus wants to merge 7 commits into
google-deepmind:mainfrom
AshNicolus:fix/peft-einsum-utils-typos
Open

Fix typos in LoRA einsum utils docstring#655
AshNicolus wants to merge 7 commits into
google-deepmind:mainfrom
AshNicolus:fix/peft-einsum-utils-typos

Conversation

@AshNicolus
Copy link
Copy Markdown

Minor docstring/comment cleanup in gemma/peft/_einsum_utils.py:

  • "reqrites a einsum" → "rewrites an einsum" (docstring of
    get_lora_einsum_str_and_shapes)
  • "This assume there's no elipsis" → "This assumes there's no ellipsis"

No behavior change.

AshNicolus and others added 7 commits October 17, 2025 22:31
Replace tf.image decoding/resizing with Pillow + NumPy + JAX.
- Convert float inputs (0..1 or 0..255) to uint8 for processing.
- Resize with PIL.BILINEAR, convert back to JAX array.
- Normalize and clip outputs to [-1, 1].
- Resolve TODO(eyvinec) to remove TF dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant