Fix mislabeled Recall row in evaluation summary and typos in Lab 8.3#35
Closed
Yassir-249 wants to merge 1 commit into
Closed
Conversation
Author
|
Resolved on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an output bug plus documentation/typo issues in
course_8/gdm_lab_8_3_classification_part_2.ipynb.Evaluation summary table prints "Precision" twice. In the metrics worked example, the summary block labels its third row
Precisionbut prints the recall values:Changed the second label to
Recall.Documentation fixes.
predictions_val.csvbut titles it "Test data classication" → "Validation data classification".promptcolumn; the ground-truth column isoutput.generate_all_predictions's docstring documented a non-existentinstructionparameter and omittedmodel; aligned it with the signature.Typos:
catergorize,verifcation,notebook,you,Adpapt,simiarly,complimentary,somehwhere,progressivly.Ran the worked-example pipeline end-to-end to confirm the fixes.