Skip to content

Fix mislabeled Recall row in evaluation summary and typos in Lab 8.3#35

Closed
Yassir-249 wants to merge 1 commit into
google-deepmind:mainfrom
Yassir-249:fix/lab-8-3-summary-recall-label-and-typos
Closed

Fix mislabeled Recall row in evaluation summary and typos in Lab 8.3#35
Yassir-249 wants to merge 1 commit into
google-deepmind:mainfrom
Yassir-249:fix/lab-8-3-summary-recall-label-and-typos

Conversation

@Yassir-249

@Yassir-249 Yassir-249 commented Jun 5, 2026

Copy link
Copy Markdown

Fixes an output bug plus documentation/typo issues in course_8/gdm_lab_8_3_classification_part_2.ipynb.

Evaluation summary table prints "Precision" twice. In the metrics worked example, the summary block labels its third row Precision but prints the recall values:

Accuracy             87.50%        83.75%        85.00%
Precision            88.71%        88.24%        86.32%
Precision            87.50%        83.75%        85.00%   <- recall values

Changed the second label to Recall.

Documentation fixes.

  • A sentence in "Interpreting the quantitative metrics results" ends mid-thought: "…or applying regularization to prevent" → completed with "overfitting."
  • The "Load and display predictions" worked example loads predictions_val.csv but titles it "Test data classication" → "Validation data classification".
  • The metrics intro says predictions are compared with the ground-truth prompt column; the ground-truth column is output.
  • generate_all_predictions's docstring documented a non-existent instruction parameter and omitted model; aligned it with the signature.

Typos: catergorize, verifcation, notebook,you, Adpapt, simiarly, complimentary, somehwhere, progressivly.

Ran the worked-example pipeline end-to-end to confirm the fixes.

upaq pushed a commit that referenced this pull request Jun 18, 2026
, #32, #33, #34, #35 and #36 by @Yassir-249.

PiperOrigin-RevId: 934537389
Change-Id: I5f6035aa2fb1ed3c291e26f9058e537ee5394996
@Yassir-249

Copy link
Copy Markdown
Author

Resolved on main — the Recall row in the evaluation summary is labelled correctly now. Closing, thanks!

@Yassir-249 Yassir-249 closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant