Make schema hash resilient to SQLite maintenance operations#320
Merged
Conversation
Contributor
Author
|
I’ve prepared the necessary changes for the PR, but I’m unsure where |
pajusmar
force-pushed
the
schema-compatibility
branch
2 times, most recently
from
b3d5dca to
e060d32
Compare
goodmami
requested changes
Mar 1, 2026
goodmami
left a comment
goodmami
left a comment
Owner
There was a problem hiding this comment.
Some suggestions, and I really don't think the COMPATIBLE_SCHEMA_HASHES set needs a new entry.
I'm still not sure we need to vacuum after removing (see discussion in the associated issue). But the change to the schema_hash function seems good once the comments are addressed.
pajusmar
force-pushed
the
schema-compatibility
branch
from
e060d32 to
0211475
Compare
pajusmar
force-pushed
the
schema-compatibility
branch
from
0211475 to
5873498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #319