Skip to content

V1.4.0 - #15

Open
gonuit wants to merge 7 commits into
masterfrom
v1.4.0
Open

V1.4.0#15
gonuit wants to merge 7 commits into
masterfrom
v1.4.0

Conversation

@gonuit

@gonuit gonuit commented Sep 8, 2021

Copy link
Copy Markdown
Owner

No description provided.

@gonuit gonuit self-assigned this Sep 8, 2021
@gonuit gonuit added the enhancement New feature or request label Sep 8, 2021

@danthedaniel danthedaniel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments 👇

Comment thread src/main.ts
const DEFAULT_DOCKERFILE_NAME = 'Dockerfile';
const DEFAULT_PROCESS_TYPE = 'web';
const DEFAULT_DOCKER_OPTIONS = '';
const DEFAULT_DOCKER_OPTIONS = '--no-cache';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the documentation. It still says the default is "".

Comment thread src/main.ts
if (!released) return;

console.log('Successfully deployed! 💪 🚀');
} catch (err) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} catch (err) {
} catch (err: unknown) {

@danthedaniel

Copy link
Copy Markdown

Relevant: #11 (comment)

@BNMetrics

BNMetrics commented Feb 14, 2023

Copy link
Copy Markdown

Hi maintainers! @gonuit @danthedaniel

Will this version be released soon?
I'm mainly looking at #19 and #12 , as this will save a lot of CPU time.

@danthedaniel

Copy link
Copy Markdown

@BNMetrics it's not my repo. I'd recommend forking as that's what my team needed to do.

@claudiowilson

Copy link
Copy Markdown

@gonuit can we get this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants