Wire mlx-lm Vulkan fused kernels#52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #51.
This PR wires the Vulkan fused-kernel work into the parent
mlx-vulkanworkspace:mlx-lmsubmodule atgoniz/mlx-lm.mlxsubmodule to include Vulkan fused fast-kernel/API support from Add Vulkan fused fast kernel paths mlx#50.mlx-lmsubmodule to include the Vulkan gated-delta implementation from Add Vulkan gated delta kernel mlx-lm#1.mlx-lmsubmodule layout.Related PRs:
Validation
Run from this parent
mlx-vulkanworkspace:./dev.sh test-cpp./dev.sh test-py./dev.sh generate./dev.sh generate --model mlx-community/Qwen3.6-35B-A3B-8bit./dev.sh run python scripts/model_generation_report.py --json-output /tmp/model_generation_report.jsonBenchmarks
./dev.sh benchmark bf16./dev.sh benchmark 8bitAdditional Qwen3.6 35B prefill check: