Add support for Vulkan on macOS#47
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 906eea22f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local moltenvk_icd="/opt/homebrew/etc/vulkan/icd.d/MoltenVK_icd.json" | ||
| if [ ! -f "$moltenvk_icd" ]; then |
There was a problem hiding this comment.
The new macOS ICD setup is hard-coded to /opt/homebrew/..., which only matches Apple Silicon Homebrew installs. On Intel macOS, Homebrew’s default prefix is /usr/local, so this check returns early and leaves VK_ICD_FILENAMES unchanged; if it still points to a mock ICD (the exact case this function is trying to fix), Vulkan commands continue to fail. Please derive the path from brew --prefix or probe both supported prefixes so macOS support works across Intel and Apple Silicon.
Useful? React with 👍 / 👎.
1 participant
No description provided.