Skip to content

limit preview cache size #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
valoq wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

limit preview cache size #2508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ func (app *app) loop() {
app.ui.draw(app.nav)
case r := <-app.nav.regChan:
app.nav.regCache[r.path] = r
app.nav.evictRegCache()

if curr := app.nav.currFile(); curr != nil {
if r.path == curr.path {
Expand Down
19 changes: 19 additions & 0 deletions nav.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,7 @@ func (nav *nav) preload() {
}

nav.regCache[file.path] = &reg{loading: true, loadTime: time.Now(), path: file.path}
nav.evictRegCache()
select {
case nav.preloadChan <- file.path:
default:
Expand Down Expand Up @@ -955,6 +956,7 @@ func (nav *nav) loadReg(path string, volatile bool) *reg {
if !ok || (!gOpts.preload && r.loading) {
r = &reg{loading: true, loadTime: time.Now(), path: path}
nav.regCache[path] = r
nav.evictRegCache()
if gOpts.preload {
select {
case nav.preloadChan <- path:
Expand Down Expand Up @@ -2021,3 +2023,20 @@ func (nav *nav) calcDirSize() error {

return nil
}

const maxRegCacheSize = 512

func (nav *nav) evictRegCache() {
if len(nav.regCache) <= maxRegCacheSize {
return
}
var oldestKey string
var oldestTime time.Time
for k, r := range nav.regCache {
if oldestKey == "" || r.loadTime.Before(oldestTime) {
oldestKey = k
oldestTime = r.loadTime
}
}
delete(nav.regCache, oldestKey)
}