couple of small fixes & improvements - #6
Open
detj wants to merge 3 commits into
Open
Conversation
auto capitalising job titles does not work well if the job title is "iOS Engineer" where intention to preserve casing makes more sense than to be automatic
detj
changed the title
this to mitigate a security vulnerability & a maybe performance boost
detj
changed the title
Specifying language in <html> improves accessibility with screen readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Do not auto capitalise job titles
Auto capitalising job titles does not work well if the job title is "iOS
Engineer" where intention to preserve casing makes more sense than to be
automatic
Fixes #5
2. Use rel="noopener" for external anchors
Whenever an anchor uses
target="_blank", it should also userel="noopener". Has security & slight performance benefits. More information here, here & hereFixes #7
3.
<html>lacks lang attributeSpecifying language in
<html>tag improves accessibility with screen readers.Fixes #8