Fix: member audit log resolution after transaction commit#23586
Open
Mauraza wants to merge 4 commits into
Open
Fix: member audit log resolution after transaction commit#23586Mauraza wants to merge 4 commits into
Mauraza wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23586 +/- ##
==========================================
+ Coverage 66.37% 66.39% +0.01%
==========================================
Files 1073 1073
Lines 117750 117751 +1
Branches 2965 2965
==========================================
+ Hits 78161 78178 +17
+ Misses 35286 35273 -13
+ Partials 4303 4300 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Ibone Gonzalez <ibone.gonzalez@suse.com>
stonezdj
force-pushed
the
fix-error-message-audit-group
branch
from
July 21, 2026 03:14
2dd7c6a to
e753ad0
Compare
Signed-off-by: Ibone Gonzalez <ibone.gonzalez@suse.com>
Mauraza
force-pushed
the
fix-error-message-audit-group
branch
from
July 22, 2026 08:12
bf9ac28 to
553ea35
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes member audit-log resolution after request transactions finish.
Changes:
- Replaces transaction-bound ORM contexts with fresh ORM instances.
- Adds partial unit coverage for ORM context handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
member.go |
Avoids querying through completed transactions. |
member_test.go |
Tests non-transactional context preservation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ibone Gonzalez <ibone.gonzalez@suse.com>
Mauraza
force-pushed
the
fix-error-message-audit-group
branch
from
July 23, 2026 10:18
9adc755 to
e5daace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
This fixes issue #23557 by resolving project member audit entries without depending on the original request transaction. As a result, member audit logs remain readable even after the request context has ended.
Issue being fixed
Fixes #23557
Please indicate you've done the following: