Skip to content

lowercase value of metric enable when migrate from old to new version#22580

Open
thuvh wants to merge 1 commit into
goharbor:mainfrom
thuvh:prepare_metric_enabled_lowercase
Open

lowercase value of metric enable when migrate from old to new version#22580
thuvh wants to merge 1 commit into
goharbor:mainfrom
thuvh:prepare_metric_enabled_lowercase

Conversation

@thuvh

@thuvh thuvh commented Nov 20, 2025

Copy link
Copy Markdown

Thank you for contributing to Harbor!

when migrate from old to new version with enabled metric, harbor.yml is generated like

metric:
  enabled: True

Issue being fixed

n/a

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@thuvh
thuvh requested a review from a team as a code owner November 20, 2025 06:16
@thuvh
thuvh force-pushed the prepare_metric_enabled_lowercase branch from f7efc93 to 832b3cd Compare November 20, 2025 06:17
@codecov

codecov Bot commented Nov 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.84%. Comparing base (c8c11b4) to head (832b3cd).
⚠️ Report is 595 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22580       +/-   ##
===========================================
+ Coverage   45.36%   65.84%   +20.47%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116095   +102762     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76446    +70397     
- Misses       6983    35409    +28426     
- Partials      301     4240     +3939     
Flag Coverage Δ
unittests 65.84% <ø> (+20.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 987 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thuvh
thuvh force-pushed the prepare_metric_enabled_lowercase branch from c0c5bce to 89cce95 Compare January 14, 2026 09:34
@github-actions

Copy link
Copy Markdown

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions Bot added the Stale label Mar 16, 2026
@thuvh

thuvh commented Mar 16, 2026

Copy link
Copy Markdown
Author

@MinerYang @stonezdj @Vad1mo please review for me

@github-actions github-actions Bot removed the Stale label Mar 17, 2026
@thuvh
thuvh force-pushed the prepare_metric_enabled_lowercase branch 2 times, most recently from 6d62c56 to d46b2cc Compare March 19, 2026 04:03
@thuvh
thuvh force-pushed the prepare_metric_enabled_lowercase branch from 2052797 to 67354c9 Compare July 23, 2026 03:30
Copilot AI review requested due to automatic review settings July 23, 2026 03:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Normalizes migrated metric enablement values to lowercase YAML booleans.

Changes:

  • Applies Jinja’s lower filter to metric enablement values.
  • Removes trailing whitespace in two migration templates.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
version_2_3_0/harbor.yml.jinja Lowercases metric enablement.
version_2_5_0/harbor.yml.jinja Lowercases metric enablement.
version_2_7_0/harbor.yml.jinja Lowercases metric enablement.
version_2_8_0/harbor.yml.jinja Lowercases metric enablement.
version_2_9_0/harbor.yml.jinja Lowercases metric enablement.
version_2_10_0/harbor.yml.jinja Lowercases metric enablement.
version_2_11_0/harbor.yml.jinja Lowercases metric enablement.
version_2_12_0/harbor.yml.jinja Lowercases metric enablement.
version_2_13_0/harbor.yml.jinja Normalizes metric output and whitespace.
version_2_14_0/harbor.yml.jinja Normalizes metric output and whitespace.
version_2_15_0/harbor.yml.jinja Lowercases metric enablement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread make/photon/prepare/migrations/version_2_5_0/harbor.yml.jinja
Signed-off-by: Hoai-Thu Vuong <thuvh87@gmail.com>
Copilot AI review requested due to automatic review settings July 23, 2026 03:36
@thuvh
thuvh force-pushed the prepare_metric_enabled_lowercase branch from 67354c9 to 760ede9 Compare July 23, 2026 03:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants