lowercase value of metric enable when migrate from old to new version#22580
lowercase value of metric enable when migrate from old to new version#22580thuvh wants to merge 1 commit into
Conversation
f7efc93 to
832b3cd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22580 +/- ##
===========================================
+ Coverage 45.36% 65.84% +20.47%
===========================================
Files 244 1073 +829
Lines 13333 116095 +102762
Branches 2719 2931 +212
===========================================
+ Hits 6049 76446 +70397
- Misses 6983 35409 +28426
- Partials 301 4240 +3939
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c0c5bce to
89cce95
Compare
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
|
@MinerYang @stonezdj @Vad1mo please review for me |
6d62c56 to
d46b2cc
Compare
2052797 to
67354c9
Compare
There was a problem hiding this comment.
Pull request overview
Normalizes migrated metric enablement values to lowercase YAML booleans.
Changes:
- Applies Jinja’s
lowerfilter to metric enablement values. - Removes trailing whitespace in two migration templates.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
version_2_3_0/harbor.yml.jinja |
Lowercases metric enablement. |
version_2_5_0/harbor.yml.jinja |
Lowercases metric enablement. |
version_2_7_0/harbor.yml.jinja |
Lowercases metric enablement. |
version_2_8_0/harbor.yml.jinja |
Lowercases metric enablement. |
version_2_9_0/harbor.yml.jinja |
Lowercases metric enablement. |
version_2_10_0/harbor.yml.jinja |
Lowercases metric enablement. |
version_2_11_0/harbor.yml.jinja |
Lowercases metric enablement. |
version_2_12_0/harbor.yml.jinja |
Lowercases metric enablement. |
version_2_13_0/harbor.yml.jinja |
Normalizes metric output and whitespace. |
version_2_14_0/harbor.yml.jinja |
Normalizes metric output and whitespace. |
version_2_15_0/harbor.yml.jinja |
Lowercases metric enablement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Hoai-Thu Vuong <thuvh87@gmail.com>
67354c9 to
760ede9
Compare
Thank you for contributing to Harbor!
when migrate from old to new version with enabled metric,
harbor.ymlis generated likeIssue being fixed
n/a
Please indicate you've done the following: