Skip to content

Add proxy cache filter proposal#280

Merged
wy65701436 merged 1 commit into
goharbor:mainfrom
stonezdj:26apr02_add_proxy_cache_filter
Jun 11, 2026
Merged

Add proxy cache filter proposal#280
wy65701436 merged 1 commit into
goharbor:mainfrom
stonezdj:26apr02_add_proxy_cache_filter

Conversation

@stonezdj

@stonezdj stonezdj commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@stonezdj
stonezdj requested review from a team as code owners April 2, 2026 09:38
@stonezdj
stonezdj force-pushed the 26apr02_add_proxy_cache_filter branch 2 times, most recently from a0559f5 to e97b57b Compare April 2, 2026 09:43
@wy65701436
wy65701436 requested a review from chlins April 21, 2026 08:48
Comment thread proposals/new/filter_repository_proxycache.md Outdated
Comment thread proposals/new/filter_repository_proxycache.md Outdated

@chlins chlins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread proposals/new/filter_repository_proxycache.md
Comment thread proposals/new/filter_repository_proxycache.md Outdated
Comment thread proposals/new/filter_repository_proxycache.md Outdated
Comment thread proposals/new/filter_repository_proxycache.md Outdated
Comment thread proposals/new/filter_repository_proxycache.md Outdated
Comment thread proposals/new/filter_repository_proxycache.md
Comment thread proposals/new/filter_repository_proxycache.md Outdated

@Vad1mo Vad1mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just like other policies in harbor the proxy policy should be first class citizen of Harbor and not a toggle during project creation.

Comment thread proposals/new/filter_repository_proxycache.md
Comment thread proposals/new/images/filter_repository_proxycache_ui.png
Comment thread proposals/new/filter_repository_proxycache.md Outdated
Comment thread proposals/new/filter_repository_proxycache.md Outdated
Comment thread proposals/new/images/filter_repository_proxycache_ui.png

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to improve wording.

@stonezdj

Comment thread proposals/new/filter_repository_proxycache.md Outdated
Comment thread proposals/new/filter_repository_proxycache.md Outdated
Comment thread proposals/new/filter_repository_proxycache.md Outdated
@bupd
bupd self-requested a review June 11, 2026 08:42

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

please fix DCO @stonezdj

@stonezdj
stonezdj force-pushed the 26apr02_add_proxy_cache_filter branch from adf7fac to 49ff735 Compare June 11, 2026 08:49
Signed-off-by: stonezdj <stonezdj@gmail.com>
@stonezdj
stonezdj force-pushed the 26apr02_add_proxy_cache_filter branch from 49ff735 to 89db192 Compare June 11, 2026 08:50

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436
wy65701436 merged commit 0251571 into goharbor:main Jun 11, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants