docs: fix bare infinitive 'allows to fill' in fill_run.Rd#116
Closed
LeonidasZhak wants to merge 1 commit into
Closed
docs: fix bare infinitive 'allows to fill' in fill_run.Rd#116LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
Changed 'allows to fill' to 'allows filling' in the @param run_for_first description. The verb 'allow' requires a gerund (allow + -ing) or a noun phrase before 'to' (allow + someone + to). Files changed: - src/fill_run.cpp (roxygen source) - R/RcppExports.R (generated) - man/fill_run.Rd (generated) - DESCRIPTION (roxygen2 version update)
Contributor
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed bare infinitive grammatical error "allows to fill" in the
@param run_for_firstdescription offill_run().Problem
The verb "allow" requires a gerund (allow + -ing) or a noun phrase before "to" (allow + someone + to). The current documentation states:
This is a bare infinitive error.
Fix
Changed "allows to fill" to "allows filling":
Files Changed
Validation
tools::checkRd('man/fill_run.Rd')— passes (no output = no errors)R CMD check --no-manual --no-tests --no-vignettes --no-examples— Status: OK (pre-existing WARNING about unstated dplyr dependency in examples, unrelated to this change)Duplicate Check
Stata Migration Relevance
The
fill_run()function is useful for Stata users migrating to R, as it provides functionality similar to Stata'sfillcommand for carrying forward values. Clear documentation of therun_for_firstparameter helps Stata users understand how to handle initial missing values, which is a common data cleaning operation.PR URL
#116