translators/postgres: respect null: false in change_column#144
Open
c-tonneslan wants to merge 1 commit into
Open
translators/postgres: respect null: false in change_column#144c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
change_column with {null: false} emitted DROP NOT NULL instead of
SET NOT NULL because the postgres builder only checked whether the
"null" key was present, not its value. Match the behavior the
caller asked for: nil or false means NOT NULL, anything else means
nullable.
Fixes gobuffalo#62
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change_column("posts", "destination_id", "integer", {null: false})emitsinstead of
SET NOT NULL. The postgres builder only checked whether thenullkey was present and ignored its value, so{null: false}(which a user reasonably writes when they want a NOT NULL column) was treated the same as{null: true}.Fix is to treat
null: falsethe same as omitting the option. Added tests for bothnull: trueandnull: false.Closes #62