facts: omit blank OS strings#960
Open
dominic-r wants to merge 1 commit into
Open
Conversation
dominic-r
added a commit
to goauthentik/authentik
that referenced
this pull request
Jun 1, 2026
Bind proxy e2e containers to per-test host ports and clean up stopped labelled containers so CI runner port collisions do not cascade across tests. Endpoint e2e blank OS version failures are fixed in goauthentik/platform#960. Agent-thread: https://sdko.org/internal/threads/019e808d-fc02-7182-bf00-c3912c0ece92 A7k-product: product A7k-product-repo: 1 Co-authored-by: Agent <agent@svc.sdko.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
==========================================
- Coverage 38.21% 38.10% -0.12%
==========================================
Files 227 227
Lines 8412 8418 +6
==========================================
- Hits 3215 3208 -7
- Misses 4812 4824 +12
- Partials 385 386 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Only set optional OS name and version facts when platform can report a non-empty value, so generated API requests omit unknown values instead of sending blank strings. Agent-thread: https://sdko.org/internal/threads/019e808d-fc02-7182-bf00-c3912c0ece92 A7k-product: platform Co-authored-by: Agent <agent@svc.sdko.net>
dominic-r
force-pushed
the
sdko/omit-empty-os-facts
branch
from
7b72148 to
48f6153
Compare
Contributor
|
🚀 Deployed on https://pr-960--authentik-pkg.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Omit optional OS fact strings when platform cannot report a non-empty value.
This follows up on 3179a52 / #949: OS version extraction was improved there, but a remaining empty result was still wrapped with
api.PtrString(""). Because the generated API client only omits nil pointers, that serialized as"version": ""during agent check-in.Related
This fixes the blank OS version producer-side issue seen by authentik endpoint e2e tests. The separate authentik proxy e2e CI fix is goauthentik/authentik#22770.
Validation
go test ./pkg/platform/facts/osgo test ./pkg/platform/facts/...git diff --check