Add option to select mixing algorithm#68
Merged
Conversation
Co-authored-by: charneykaye <8584836+charneykaye@users.noreply.github.com>
Co-authored-by: charneykaye <8584836+charneykaye@users.noreply.github.com>
Copilot stopped work on behalf of
charneykaye due to an error
January 6, 2026 10:00
Contributor
|
@copilot try again |
Co-authored-by: charneykaye <8584836+charneykaye@users.noreply.github.com>
Contributor
Author
Done! The mixing algorithm selection feature is now complete. Implemented in commit 19867ec:
Users can now choose their mixing algorithm: spec := spec.AudioSpec{
Freq: 48000,
Format: spec.AudioF32,
Channels: 2,
Algorithm: spec.MixLinear, // or spec.MixLogarithmic (default)
} |
Co-authored-by: charneykaye <8584836+charneykaye@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add option to select mixing algorithm
Add option to select mixing algorithm
Jan 7, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Plan: Choose Mixing Algorithm
Summary
Added the ability to choose between two mixing algorithms:
Changes Made
MixAlgorithmtype and constants (MixLogarithmic,MixLinear) tobind/spec/spec.goAlgorithmfield toAudioSpecstructure (defaults to logarithmic for backward compatibility)mixLinearClamp()function for linear mixingmixApplyAlgorithm()dispatcher to select algorithm at runtimeConfigure()to set the mixing algorithm from AudioSpecUsage Example
Testing
All tests pass including:
Backward Compatibility
The feature is fully backward compatible - existing code continues to use logarithmic mixing by default when
Algorithmfield is not specified.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.