dap: make variable load limits configurable#4385
Open
larrasket wants to merge 1 commit into
Open
Conversation
The DAP server hardcoded MaxStringLen (512) and MaxArrayValues (64) in
DefaultLoadConfig with no way to adjust them, so debugging sessions that
need to see longer strings or larger collections had to page through
reloads or use the dlv connection workaround.
Add maxStringLen and maxArrayValues to the launch/attach configuration
and to the config evaluation request ("dlv config maxStringLen 4096" in
the debug console). The limits override DefaultLoadConfig through a new
Session.loadConfig method; contexts that deliberately relax a limit
(single string evaluation, call return values, paging) keep doing so on
top of the configured base.
Fixes go-delve#4064
aarzilli
reviewed
Jul 3, 2026
|
|
||
| // Maximum number of bytes loaded for strings. | ||
| // Default is 512. | ||
| MaxStringLen int `json:"maxStringLen,omitempty"` |
Member
There was a problem hiding this comment.
Changes to this struct need to also be documented by updating the corresponding json descriptions in vscode-go. For example: https://go-review.googlesource.com/c/vscode-go/+/753000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the server hardcoded MaxStringLen (512) and MaxArrayValues (64) in DefaultLoadConfig with no way to adjust them, debugging sessions that need to see longer strings or larger collections had to page through reloads or use the dlv connection workaround.
this adds maxStringLen and maxArrayValues to the launch/attach configuration and to the config evaluation request.
Fixes #4064