go.mod: update disassembler#4379
Draft
aarzilli wants to merge 1 commit into
Draft
Conversation
Supports disassembling more AVX, AVX2 and AVX-512 instructions.
aarzilli
commented
Jun 26, 2026
|
|
||
| asmInst.Size = inst.Len | ||
| asmInst.Bytes = mem[:asmInst.Size] | ||
| patchPCRelX86(asmInst.Loc.PC, &inst) |
Member
Author
There was a problem hiding this comment.
This change is somewhat scary because this line has been there since 2016. I remove it (and add the handling of x86asm.Rel arguments to resolveCallArgX86) because changing the arguments of CALL instructions to immediates violates assumptions in the formatting code of golang.org/x/arch/x86/x86asm, see the comment in golang.org/x/arch/x86/x86asm/plan9x.go function plan9Arg, case Imm.
It should be fine since the other architectures, in particular arm64, does not patch out relative addresses, so this makes the two codepaths more similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports disassembling more AVX, AVX2 and AVX-512 instructions.