Use \r\n (CRLF) newlines by default#777
Open
ybasket wants to merge 1 commit into
Open
Conversation
To fully comply with ISO 4180 by default, this changes the default newline to `\r\n`. It also extracts both the default separator and the newline values into constants so they're not repeated (potentially inconsistently) across the code.
ybasket
commented
Jun 1, 2026
| /** | ||
| * Default separator value for CSV data according to RFC-4180. Note that all pipes allow customizing this. | ||
| */ | ||
| val csvDataDefaultSeparator: Char = ',' |
Collaborator
Author
There was a problem hiding this comment.
I don't particularly like the csvData prefix, but people will usually have import fs2.data.csv._ and I don't want source clashes with locally defined defaultSeparator and defaultNewline – just sitting on a codebase where those are actually defined 🙄 Open for better ideas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fully comply with RFC 4180 by default, this changes the default newline to
\r\n. It also extracts both the default separator and the newline values into constants so they're not repeated (potentially inconsistently) across the code.