Add ++ to concatenate CSV rows#776
Open
ybasket wants to merge 1 commit into
Open
Conversation
When serializing nested case classes, it comes in handy to be able to concatenate CSV rows (with or without headers). Also adds Order instances for (CSV)Row.
ybasket
commented
Jun 1, 2026
| } | ||
|
|
||
| implicit val orderRow: Order[Row] = Order.by(r => (r.values, r.line)) | ||
| implicit def orderCsvRow[Header: Order]: Order[CsvRow[Header]] = |
Collaborator
Author
There was a problem hiding this comment.
I assume that for the usual header types an Order exists. If that's too strong, we can always introduce a lower priority implicit later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When serializing nested case classes, it comes in handy to be able to concatenate CSV rows (with or without headers), hence this adds a
++(feel free to bikeshed the name). Also addsOrderinstances for (CSV)Row as they're useful as well.