Skip to content

Replace native tooltips with Tooltip component #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyush-3020 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace native tooltips with Tooltip component #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions frontend/src/components/DayDetailDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,24 +246,26 @@ function DayDetailRow({
{item.event.title}
</p>
{item.kind === "external" && (
<span title="Linked calendar (read-only)" style={{ color }}>
<svg
xmlns="http://www.w3.org/2000/svg"
width="11"
height="11"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
strokeWidth="2.5"
strokeLinecap="round"
strokeLinejoin="round"
className="flex-shrink-0"
>
<path d="M10 13a5 5 0 0 0 7.54.54l3-3a5 5 0 0 0-7.07-7.07l-1.72 1.71" />
<path d="M14 11a5 5 0 0 0-7.54-.54l-3 3a5 5 0 0 0 7.07 7.07l1.71-1.71" />
</svg>
</span>
)}
<Tooltip label="Linked calendar (read-only)">
<span style={{ color }}>
<svg
xmlns="http://www.w3.org/2000/svg"
width="11"
height="11"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
strokeWidth="2.5"
strokeLinecap="round"
strokeLinejoin="round"
className="flex-shrink-0"
>
<path d="M10 13a5 5 0 0 0 7.54.54l3-3a5 5 0 0 0-7.07-7.07l-1.72 1.71" />
<path d="M14 11a5 5 0 0 0-7.54-.54l-3 3a5 5 0 0 0 7.07 7.07l1.71-1.71" />
</svg>
</span>
</Tooltip>
)}
</div>
<p className="text-meta text-foreground-muted mt-0.5">{timeLabel}</p>
{item.event.location && (
Expand Down
8 changes: 5 additions & 3 deletions frontend/src/components/methods/VariationNotesPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,11 @@ function SaveStatusIndicator({
}
if (status === "error") {
return (
<span className="text-meta text-red-600 dark:text-red-300 flex items-center gap-1" title="Will retry on the next edit">
Save failed
</span>
<Tooltip label="Will retry on the next edit">
<span className="text-meta text-red-600 dark:text-red-300 flex items-center gap-1">
Save failed
</span>
</Tooltip>
);
}
if (hasUnsavedChanges) {
Expand Down