Skip to content

fix(librd): reject FetchInfo requests for unknown topics instead of panicking #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(librd): reject FetchInfo requests for unknown topics instead of panicking #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions kafka/adaptors/librd/admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,22 @@ func (a *kAdmin) FetchInfo(topics []string) (map[string]*kafka.Topic, error) {
return nil, err
}

// fetchInfo silently drops topics that the broker does not know
// about. If none of the requested topics resolved, the resources
// slice below stays empty and librd's DescribeConfigs panics with
// an out-of-range index when the empty slice is passed in (#19).
// Surface the missing topics to the caller as an error rather than
// crashing on the next line.
if len(topicInfo) != len(topics) {
var missing []string
for _, t := range topics {
if _, ok := topicInfo[t]; !ok {
missing = append(missing, t)
}
}
return nil, errors.Errorf(`no metadata returned for topic(s) %v (do they exist?)`, missing)
}

for _, meta := range topicInfo {
resources = append(resources, librdKafka.ConfigResource{
Type: librdKafka.ResourceTopic,
Expand Down