Fix verbose progress leaking into redirected stdout#31
Conversation
|
Caution Review failedFailed to post review comments. GitHub was unavailable or timed out while CodeRabbit was posting the review. Please request a new review later if the pull request still needs one. This happened while posting 1 inline comment. Use ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout. (2)
🧰 Additional context used🪛 golangci-lint (2.12.2)pkg/client/transcribe_test.go[error] 176-176: Error return value of (errcheck) [error] 177-177: Error return value of (errcheck) 📝 WalkthroughWalkthroughVerbose transcription progress, completion, and error messages are redirected from stdout to stderr. A new test verifies stderr output during a processing-to-completed polling sequence and confirms stdout remains empty. ChangesTranscription output routing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
-vprogress/spinner messages to stderr instead of stdout> output.json) as clean JSON onlyTest plan
gladia transcribe <url> -o json -v > output.json— file is valid JSON, progress still shows in the terminalgo test ./pkg/client/ -run TestPollForTranscriptionResult_verboseGoesToStderrSummary by CodeRabbit