Improved code folding + DAP fixup - #63
Open
IanQS wants to merge 8 commits into
Open
Conversation
Claude Fixup of code folding
added in changes from slawomirlech
Owner
|
Please resolve the failures.. thanks |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Folding
The original PR on the helix repo helix-editor#14593 had some limitations including being unable to fold over arbitrary regions and auto-magically fold over sections/subsections. See my question on that PR. I used an LLM to help me address the limitations I brought up - they were driving me crazy on a project. From my personal tests this does everything I need it to now without issues.
DAP Fixing
I didn't do anything - this was all work by slawomirlech on this branch: helix-editor#15593 on the main helix repo. One caveat is that I think it only works on unix.
Feel free to take some/any of this. I thought I'd just offer it up so no one has to burn through tokens redoing this