Make auto-lock non-blocking#1
Open
cbjornram wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @giuliolibrando,
Thank you for posting this project, as it made the modification of an apartment intercom system much easier. As I needed my doorlock to be open for 3 seconds, I ran into issues as this was done using delay(), blocking the rest of the sketch/HomeSpan. Therefore, I rewrote it to be non-blocking using millis() instead.
The changes are quite large though, leaving the main sketch slightly more difficult to understand for someone new to HomeSpan or Arduino. Feel free to pull this in or leave it out according to your liking, I mostly wanted to post it as a non-blocking alternative.
Thanks again and all the best!
Christoffer