feat(workflow): wire Grug TPM bot - DoR gate + weekly pulse#76
Merged
Conversation
Calls reusable workflows at githumps/grug (public). Static DoR check advisory (strict: false) for first rollout; flip to strict: true once the repo's PR template aligns with DoR (Why / Acceptance / Estimate / Out-of-scope / Issue-link). Prereqs (already done): - grug-bot environment created - POOLSIDE_API_KEY env-scoped secret set Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Grug — automated TPM check✅ Definition of Ready — 4/5 pass, 1 warnings
Grug's read on scope
Static checks are blocking. LLM read is advisory. Re-runs on every push. Edit PR body, push empty commit, or comment |
Comment on lines
+17
to
+23
| grug: | ||
| name: Grug · DoR check | ||
| uses: githumps/grug/.github/workflows/_reusable.grug-pr-gate.yml@main | ||
| with: | ||
| strict: false | ||
| secrets: | ||
| poolside_api_key: ${{ secrets.POOLSIDE_API_KEY }} |
There was a problem hiding this comment.
Bug: The workflow is missing the environment: grug-bot declaration, causing the environment-scoped POOLSIDE_API_KEY secret to be an empty string and breaking API authentication.
Severity: HIGH
Suggested Fix
Add environment: grug-bot to the job definition within .github/workflows/grug.pr-gate.yml to grant it access to the environment-scoped POOLSIDE_API_KEY secret.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: .github/workflows/grug.pr-gate.yml#L17-L23
Potential issue: The `grug.pr-gate.yml` workflow attempts to use
`secrets.POOLSIDE_API_KEY`, which is an environment-scoped secret tied to the `grug-bot`
environment. However, the workflow job fails to declare `environment: grug-bot`.
Consequently, `secrets.POOLSIDE_API_KEY` resolves to an empty string, which is then
passed to reusable workflows. This causes all API calls requiring this key to fail with
authentication errors, rendering the workflow's core functionality inoperative.
Also affects:
.github/workflows/grug.pulse.yml
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Wire up Grug TPM bot caller workflows so PRs get Definition-of-Ready feedback + weekly iteration pulse. Grug source-of-truth at githumps/grug (public). Advisory mode (strict: false) for first rollout, flip to strict: true once PR template aligns.
Adds
.github/workflows/grug.pr-gate.yml— every PR open/edit/sync.github/workflows/grug.pulse.yml— Mon 13:00Z weekly groom signalAcceptance criteria
grug-botGitHub Environment created (out-of-band)POOLSIDE_API_KEYenv-scoped secret set (out-of-band)Out of scope
Size: XS
Refs: githumps/grug#1