fix(integrations): declare OmpIntegration multi_install_safe#3650
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Declares Omp safe for co-installation due to its isolated command directory.
Changes:
- Enables
multi_install_safefor Omp. - Adds a regression test for the declaration.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/omp/__init__.py |
Marks Omp multi-install safe. |
tests/integrations/test_integration_omp.py |
Verifies the safety flag. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
Collaborator
|
Please address Copilot feedback |
Contributor
Author
|
Thanks! The Copilot feedback is addressed in a388787: added the alphabetized |
Collaborator
|
Please resolve conflicts |
OmpIntegration is a plain MarkdownIntegration whose files live only under its isolated, static root .omp/commands/, disjoint from every other integration. But it never declared multi_install_safe, so it inherited the IntegrationBase default False — leaving `specify integration status` in a permanent unsafe-multi-install ERROR state whenever omp is co-installed alongside another agent, with no acknowledgment path. Add `multi_install_safe = True`, mirroring the isolated MarkdownIntegration cohort (qwen, shai, qodercli, junie, kilocode) and the kiro-cli github#3471 fix. The parametrized registry isolation contracts auto-include omp once the flag is set and pass (.omp/commands is isolated and its manifest disjoint). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Declaring OmpIntegration multi_install_safe means the reference table in docs/reference/integrations.md (which states it lists all currently declared multi-install-safe integrations) should include it. Add the alphabetized omp row with its .omp/commands isolation path. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jawwad-ali
force-pushed
the
fix/omp-multi-install-safe
branch
from
July 23, 2026 15:47
a388787 to
6d00160
Compare
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OmpIntegrationis a plainMarkdownIntegrationwhose files live only under its isolated, static root.omp/commands/— disjoint from every other integration. But it never declaredmulti_install_safe, so it inherited theIntegrationBasedefaultFalse.Why it matters
Per the isolation policy (and the merged kiro-cli fix #3471), an integration that is fully isolated but not declared safe leaves
specify integration statusin a permanentunsafe-multi-installERROR state whenever omp is co-installed alongside another agent — with no acknowledgment path. Omp meets none of the documented exclusion criteria (it doesn't share a command dir, needs no dynamic path, merges no shared settings).Fix
Add
multi_install_safe = True, mirroring the isolatedMarkdownIntegrationcohort (qwen,shai,qodercli,junie,kilocode) and the kiro-cli #3471 precedent. One-line class attribute.Tests
tests/integrations/test_integration_omp.py::TestOmpIntegration::test_multi_install_safe— asserts the flag (fails before the fix). The parametrized registry isolation contracts (test_registry.py) auto-include omp once the flag is set and all pass —.omp/commandsis isolated and its manifest disjoint from every other safe integration.ruffclean.AI-assisted: authored with Claude Code. I verified
.omp/is unique across all integrations and that the full registry isolation contracts pass with the flag set.