Skip to content

chore: align ruff lint scope#3139

Merged
mnriem merged 1 commit into
github:mainfrom
PascalThuet:chore/ruff-ci-scope
Jul 21, 2026
Merged

chore: align ruff lint scope#3139
mnriem merged 1 commit into
github:mainfrom
PascalThuet:chore/ruff-ci-scope

Conversation

@PascalThuet

@PascalThuet PascalThuet commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What

  • Expand the Python Ruff CI job from src/ to src tests.
  • Replace an invalid test-only # noqa: unreachable with # pragma: no cover.
  • Remove the unused BASH import exposed by linting the test suite.
  • Keep the local development guide aligned with the CI lint command.

Why

PR #3132 added Ruff subprocess-security checks that were verified against tests locally, but CI only linted src/. This keeps CI aligned with the intended src tests Ruff scope and removes the pre-existing lint issues exposed by that scope.

Validation

  • uvx ruff check src tests
  • .venv/bin/python -m pytest tests/test_github_http.py tests/extensions/test_update_agent_context_feature_json.py tests/test_github_workflows.py -q (36 passed, 3 skipped)
  • .venv/bin/python -m pytest -o addopts="" -q (4431 passed, 112 skipped)
  • git diff --check

Assisted-by: Codex (model: GPT-5, autonomous)
@PascalThuet
PascalThuet force-pushed the chore/ruff-ci-scope branch from 6e702b3 to 3295f98 Compare July 20, 2026 15:06
@PascalThuet
PascalThuet marked this pull request as ready for review July 20, 2026 15:07
@PascalThuet

Copy link
Copy Markdown
Contributor Author

Review round summary: rebased onto current main, expanded Ruff coverage to src tests, fixed the invalid test pragma and the unused import exposed by the broader lint scope, and aligned the local-development documentation. Validation passed with Ruff, 36 targeted tests (3 skipped), and the full suite (4,431 passed; 112 skipped). Commit: 3295f9868a3145eea735743101e804a29665332e.

Posted on behalf of @PascalThuet by Codex (model: GPT-5, autonomous).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns Ruff linting across CI and local development by including the test suite.

Changes:

  • Expands Ruff checks to src tests.
  • Fixes test-suite lint findings.
  • Updates local development documentation.
Show a summary per file
File Description
.github/workflows/test.yml Adds tests to CI lint scope.
docs/local-development.md Documents the updated lint command.
tests/test_github_http.py Uses the correct coverage exclusion pragma.
tests/extensions/test_update_agent_context_feature_json.py Removes an unused import.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Medium

@mnriem
mnriem merged commit ec45dbd into github:main Jul 21, 2026
12 checks passed
@mnriem

mnriem commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants