chore: align ruff lint scope#3139
Merged
Merged
Conversation
Assisted-by: Codex (model: GPT-5, autonomous)
PascalThuet
force-pushed
the
chore/ruff-ci-scope
branch
from
July 20, 2026 15:06
6e702b3 to
3295f98
Compare
PascalThuet
marked this pull request as ready for review
July 20, 2026 15:07
Contributor
Author
|
Review round summary: rebased onto current Posted on behalf of @PascalThuet by Codex (model: GPT-5, autonomous). |
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns Ruff linting across CI and local development by including the test suite.
Changes:
- Expands Ruff checks to
src tests. - Fixes test-suite lint findings.
- Updates local development documentation.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/test.yml |
Adds tests to CI lint scope. |
docs/local-development.md |
Documents the updated lint command. |
tests/test_github_http.py |
Uses the correct coverage exclusion pragma. |
tests/extensions/test_update_agent_context_feature_json.py |
Removes an unused import. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Medium
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
src/tosrc tests.# noqa: unreachablewith# pragma: no cover.BASHimport exposed by linting the test suite.Why
PR #3132 added Ruff subprocess-security checks that were verified against tests locally, but CI only linted
src/. This keeps CI aligned with the intendedsrc testsRuff scope and removes the pre-existing lint issues exposed by that scope.Validation
uvx ruff check src tests.venv/bin/python -m pytest tests/test_github_http.py tests/extensions/test_update_agent_context_feature_json.py tests/test_github_workflows.py -q(36 passed, 3 skipped).venv/bin/python -m pytest -o addopts="" -q(4431 passed, 112 skipped)git diff --check