[codex] Improve search match highlighting - #60
Merged
Merged
Conversation
Separate search match coloring from header/path styling so terminal output keeps query matches visible in titles, summaries, and path segments. Use yellow for matched spans while preserving cyan for headers.
jlitola
marked this pull request as ready for review
May 5, 2026 11:48
Carry the backend query through search-status result payloads so completed and partial follow-up output can apply the same location-term highlights as immediate search output. Make fallback query-term highlighting deterministic by prioritizing longer overlapping terms, and preserve quoted phrases as phrase terms for path highlighting.
jlitola
marked this pull request as draft
May 5, 2026 11:59
jlitola
marked this pull request as ready for review
May 5, 2026 11:59
Document the reduced search-status query echo, make local term ordering explicit, preserve quoted terms verbatim for location highlighting, and lock longest-overlap behavior with CLI coverage.
jlitola
marked this pull request as draft
May 5, 2026 12:03
jlitola
marked this pull request as ready for review
May 5, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves terminal search readability by separating header/path styling from search-match styling.
search_statusresult payloads so async/follow-up output gets the same location highlightingWhy
Search output could match on file paths, but path matches were visually lost because both the header and highlight spans used the same cyan style. Yellow match spans make the actual matched term visible while preserving the existing header hierarchy.
Review Notes
Claude review cleanup addressed:
search_statushighlighting asymmetry by threadingresult.query.rawthrough status payloadsValidation
bun testbun run typecheckbun run format:checkbun run lintbun run buildbun run smoke:clibun run smoke:mcp